Refactor the logging and add support for the use of a log-config file #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam.Dybbroe <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 77.90% 77.63% -0.28%
==========================================
Files 18 19 +1
Lines 4001 3814 -187
==========================================
- Hits 3117 2961 -156
+ Misses 884 853 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Adam.Dybbroe <[email protected]>
Signed-off-by: Adam.Dybbroe <[email protected]>
Signed-off-by: Adam.Dybbroe <[email protected]>
Signed-off-by: Adam.Dybbroe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR it shall be possible to run e.g. the
move_it_client.pyscript with a log-config file defining the log-handlers etc. For instance like this:python bin/move_it_client.py -c </path/to/my/log/config/file/>/log_config.yaml ./example_move_it_client.cfgI have also tried to refactor the logging support a bit collecting it in a
logging.pymodule.But I might need some help soritng out the continuous support of the logging without providing a log-config yaml file!
AUTHORS.mdif not there already